CI script: use jq to filter and output final format; ensure default target dir #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Aug 11, 2024
spookyvision
changed the title
|
@jamesmunns (low importance) if you feel like giving this a quick glance |
|
I'm fine with just merging this whenever, but if you want to wait for @jamesmunns, that's fine too. I'm pretty sure the new code does the right thing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR uses jq's (admittedly quite weird) builtin capabilities to create a list of crates to build docs for, instead of the previous grep/cut/sed/tr pipe.
It also unsets
$CARGO_TARGET_DIRto ensure build products will reside in./target.